PMD Results

The following document contains the results of PMD 5.5.1.

Files

com/buckosoft/PicMan/PicManService/PicFilterSOAP.java

Violation Line
Useless parentheses. 122
Useless parentheses. 127
Useless parentheses. 128–129
Useless parentheses. 130
Useless parentheses. 131–132
Useless parentheses. 133
Useless parentheses. 134–135

com/buckosoft/PicMan/PicManService/PicManServiceProxy.java

Violation Line
Useless parentheses. 18
Avoid empty catch blocks 27

com/buckosoft/PicMan/PicManService/PicManServiceSOAPStub.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 846
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 846
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 846
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 846

com/buckosoft/PicMan/PicManService/PicManService_PortType.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 20
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 77

com/buckosoft/PicMan/PicManService/PicManService_Service.java

Violation Line
Avoid modifiers which are implied by the context 11
Avoid modifiers which are implied by the context 13
Avoid modifiers which are implied by the context 15

com/buckosoft/PicMan/business/BatchManager.java

Violation Line
Useless parentheses. 88
Useless parentheses. 90
Useless parentheses. 114
Useless parentheses. 117
Useless parentheses. 120
Useless parentheses. 122
Useless parentheses. 140

com/buckosoft/PicMan/business/ContactManager.java

Violation Line
Useless parentheses. 170
Useless parentheses. 191
Useless parentheses. 200
Useless parentheses. 202
Useless parentheses. 203
These nested if statements could be combined 264–269
These nested if statements could be combined 265–268
Useless parentheses. 308
Useless parentheses. 316
These nested if statements could be combined 321–324
Useless parentheses. 323
Useless parentheses. 330
Useless parentheses. 343
Useless parentheses. 385
Useless parentheses. 387
Useless parentheses. 389
Useless parentheses. 390
Useless parentheses. 415
Useless parentheses. 417
Useless parentheses. 432
Useless parentheses. 434

com/buckosoft/PicMan/business/MetaSetChangeAuditor.java

Violation Line
These nested if statements could be combined 51–56

com/buckosoft/PicMan/business/NewPicScannerImpl.java

Violation Line
Useless parentheses. 64
Useless parentheses. 90
Useless parentheses. 109
Useless parentheses. 113
Useless parentheses. 119
Useless parentheses. 130
Useless parentheses. 132
Useless parentheses. 187
Useless parentheses. 194

com/buckosoft/PicMan/business/PicImporterImpl.java

Violation Line
Useless parentheses. 62
Useless parentheses. 97
Useless parentheses. 99
Useless parentheses. 106
Useless parentheses. 108
Useless parentheses. 114
Useless parentheses. 120
Useless parentheses. 134
Useless parentheses. 142
Useless parentheses. 155
Useless parentheses. 160
Useless parentheses. 162
Useless parentheses. 170
Useless parentheses. 178
Useless parentheses. 196
Avoid empty catch blocks 213
Useless parentheses. 235

com/buckosoft/PicMan/business/PicManFacade.java

Violation Line
Avoid modifiers which are implied by the context 38

com/buckosoft/PicMan/business/PicManImpl.java

Violation Line
Useless parentheses. 102
Useless parentheses. 184
Useless parentheses. 186
Useless parentheses. 192
Useless parentheses. 196
Useless parentheses. 198
Useless parentheses. 206
Useless parentheses. 210
Useless parentheses. 214
Useless parentheses. 224
Useless parentheses. 281
Useless parentheses. 308
Useless parentheses. 316
Useless parentheses. 323
Useless parentheses. 330
Useless parentheses. 348
Useless parentheses. 355
Useless parentheses. 405
Useless parentheses. 412
Useless parentheses. 419
Useless parentheses. 437
Useless parentheses. 444
Useless parentheses. 451
Useless parentheses. 465
Useless parentheses. 473
Useless parentheses. 482
Useless parentheses. 489
Useless parentheses. 501

com/buckosoft/PicMan/business/PosterManager.java

Violation Line
Useless parentheses. 63
Useless parentheses. 94
Useless parentheses. 95

com/buckosoft/PicMan/business/SpringGlue.java

Violation Line
Useless parentheses. 30

com/buckosoft/PicMan/business/SyncManager_Old.java

Violation Line
Useless parentheses. 90
Useless parentheses. 92
Useless parentheses. 93
Useless parentheses. 94
Useless parentheses. 95
Useless parentheses. 96
Useless parentheses. 97
Useless parentheses. 99
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.IntHolder' due to existing import 'javax.xml.rpc.holders.IntHolder' 156
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.StringHolder' due to existing import 'javax.xml.rpc.holders.StringHolder' 157
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.IntHolder' due to existing import 'javax.xml.rpc.holders.IntHolder' 158
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.StringHolder' due to existing import 'javax.xml.rpc.holders.StringHolder' 159
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.CalendarHolder' due to existing import 'javax.xml.rpc.holders.CalendarHolder' 160
Unnecessary use of fully qualified name 'javax.xml.rpc.holders.CalendarHolder' due to existing import 'javax.xml.rpc.holders.CalendarHolder' 161
Avoid empty catch blocks 223–224

com/buckosoft/PicMan/business/common/PicManCommonImpl.java

Violation Line
Useless parentheses. 58
Useless parentheses. 66
Useless parentheses. 80
Useless parentheses. 94

com/buckosoft/PicMan/business/common/UserFactory.java

Violation Line
Useless parentheses. 54
Useless parentheses. 61
Useless parentheses. 71
Useless parentheses. 75
Useless parentheses. 77

com/buckosoft/PicMan/business/contact/ContactEngine.java

Violation Line
Useless parentheses. 92
Useless parentheses. 102
Useless parentheses. 123
Useless parentheses. 125
Useless parentheses. 139
Useless parentheses. 155
Useless parentheses. 160

com/buckosoft/PicMan/business/contact/PosterEngine.java

Violation Line
Useless parentheses. 55
Useless parentheses. 77
Useless parentheses. 88
Useless parentheses. 90
Useless parentheses. 146
Useless parentheses. 156
Useless parentheses. 232

com/buckosoft/PicMan/business/contact/engine/QuadrantSets.java

Violation Line
Useless parentheses. 63
Useless parentheses. 117
Useless parentheses. 124
Useless parentheses. 162

com/buckosoft/PicMan/business/contact/engine/Ribbon.java

Violation Line
Useless parentheses. 46
Useless parentheses. 82
Useless parentheses. 88

com/buckosoft/PicMan/business/contact/engine/SequentialSets.java

Violation Line
Useless parentheses. 61
Useless parentheses. 113
Useless parentheses. 120
Useless parentheses. 158

com/buckosoft/PicMan/business/mosaic/MosaicEngine.java

Violation Line
Useless parentheses. 122
Useless parentheses. 123
Useless parentheses. 131
Useless parentheses. 132
Useless parentheses. 139
Useless parentheses. 140
Useless parentheses. 148
Useless parentheses. 149
Useless parentheses. 211
Useless parentheses. 223
Useless parentheses. 230
Useless parentheses. 350

com/buckosoft/PicMan/business/mosaic/MosaicMan.java

Violation Line
Useless parentheses. 97
Useless parentheses. 104
Useless parentheses. 117
Useless parentheses. 135
Useless parentheses. 148
Useless parentheses. 155
Useless parentheses. 176

com/buckosoft/PicMan/business/mosaic/MosaicManDevelopment.java

Violation Line
Useless parentheses. 100
Useless parentheses. 113
Useless parentheses. 130
Useless parentheses. 154

com/buckosoft/PicMan/business/mosaic/engine/FirstRibbon.java

Violation Line
Useless parentheses. 54
Useless parentheses. 58
This for loop could be simplified to a while loop 78–130
Useless parentheses. 129
Useless parentheses. 132
This for loop could be simplified to a while loop 140–160
Useless parentheses. 168
Useless parentheses. 170

com/buckosoft/PicMan/business/mosaic/engine/FourthRibbon.java

Violation Line
Useless parentheses. 94
Useless parentheses. 101
Useless parentheses. 160
Useless parentheses. 197
Useless parentheses. 257
Useless parentheses. 318
Useless parentheses. 368
Useless parentheses. 417

com/buckosoft/PicMan/business/mosaic/engine/HSVRibbon.java

Violation Line
Useless parentheses. 65
Useless parentheses. 72
Useless parentheses. 183
Useless parentheses. 227
Useless parentheses. 229

com/buckosoft/PicMan/business/mosaic/engine/SampleMaker.java

Violation Line
Useless parentheses. 62
Useless parentheses. 66
Useless parentheses. 144

com/buckosoft/PicMan/business/mosaic/engine/SecondRibbon.java

Violation Line
Useless parentheses. 63
Useless parentheses. 70
Useless parentheses. 139
Useless parentheses. 182
Useless parentheses. 226
Useless parentheses. 228

com/buckosoft/PicMan/business/mosaic/engine/ThirdRibbon.java

Violation Line
Useless parentheses. 91
Useless parentheses. 98
Useless parentheses. 156
Useless parentheses. 191
Useless parentheses. 236
Useless parentheses. 280
Useless parentheses. 329
Useless parentheses. 378

com/buckosoft/PicMan/business/mosaic/engine/VectorRibbon.java

Violation Line
Useless parentheses. 56
Useless parentheses. 60
This for loop could be simplified to a while loop 81–128
Useless parentheses. 130
This for loop could be simplified to a while loop 139–159
Useless parentheses. 167
Useless parentheses. 169

com/buckosoft/PicMan/business/util/Classes.java

Violation Line
Avoid empty catch blocks 32–34
Avoid empty if statements 46–48
Useless parentheses. 51

com/buckosoft/PicMan/business/util/CopyFile.java

Violation Line
Useless parentheses. 32
These nested if statements could be combined 35–39

com/buckosoft/PicMan/db/ChainsDao.java

Violation Line
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 58

com/buckosoft/PicMan/db/ChainsDaoJdbc.java

Violation Line
Useless parentheses. 58
Useless parentheses. 65
Useless parentheses. 90
Useless parentheses. 177
Avoid unused constructor parameters such as 'name'. 191
Avoid unused constructor parameters such as 'cid'. 197
Useless parentheses. 222
Useless parentheses. 367

com/buckosoft/PicMan/db/ContactsDaoJdbc.java

Violation Line
Useless parentheses. 94
Useless parentheses. 103
Useless parentheses. 165
Useless parentheses. 181
Useless parentheses. 189
Useless parentheses. 194
Useless parentheses. 204
Useless parentheses. 204
Avoid unused constructor parameters such as 'name'. 220
Avoid unused constructor parameters such as 'cid'. 220
Useless parentheses. 234
Avoid unused constructor parameters such as 'name'. 272
Avoid unused constructor parameters such as 'cid'. 278
Avoid unused constructor parameters such as 'name'. 278
Avoid unused constructor parameters such as 'date'. 285
Avoid unused constructor parameters such as 'unused1'. 295
Avoid unused constructor parameters such as 'unused'. 295
Avoid unused constructor parameters such as 'unused1'. 302
Avoid unused constructor parameters such as 'unused0'. 302
Avoid empty catch blocks 313
Avoid empty catch blocks 316
Useless parentheses. 317

com/buckosoft/PicMan/db/DatabaseFacade.java

Violation Line
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 139

com/buckosoft/PicMan/db/DatabaseImpl.java

Violation Line
Useless parentheses. 244
Useless parentheses. 265
Useless parentheses. 283
Useless parentheses. 296
Useless parentheses. 310
Useless parentheses. 317
Useless parentheses. 327
Useless parentheses. 334
Useless parentheses. 340
Useless parentheses. 347
Useless parentheses. 384
Useless parentheses. 391
Useless parentheses. 401
Useless parentheses. 408
Useless parentheses. 415
Useless parentheses. 422
Useless parentheses. 429
These nested if statements could be combined 520–523
Useless parentheses. 537
Useless parentheses. 544
Useless parentheses. 555
Useless parentheses. 585
Useless parentheses. 592
Useless parentheses. 603
Useless parentheses. 610
Useless parentheses. 617
Useless parentheses. 624
Useless parentheses. 649
Useless parentheses. 656
Useless parentheses. 681
Useless parentheses. 707
Useless parentheses. 718
Useless parentheses. 725
Useless parentheses. 752
Useless parentheses. 759
Useless parentheses. 766
Useless parentheses. 777
Useless parentheses. 784
Useless parentheses. 791
Useless parentheses. 798
These nested if statements could be combined 829–831
Useless parentheses. 849
Useless parentheses. 868
Useless parentheses. 879
Useless parentheses. 886
Useless parentheses. 900
Useless parentheses. 907
Useless parentheses. 919
Useless parentheses. 928
Useless parentheses. 935
Useless parentheses. 942
Useless parentheses. 950
Useless parentheses. 958
Useless parentheses. 960
Useless parentheses. 961
Useless parentheses. 967
Useless parentheses. 975
Useless parentheses. 983
Useless parentheses. 985
Useless parentheses. 988
Useless parentheses. 995
Useless parentheses. 998
Useless parentheses. 1001
Useless parentheses. 1015
Useless parentheses. 1127
Useless parentheses. 1135
Useless parentheses. 1148
Useless parentheses. 1175
Useless parentheses. 1192
Useless parentheses. 1199
Useless parentheses. 1206
Useless parentheses. 1227
Useless parentheses. 1252
Useless parentheses. 1259
Useless parentheses. 1267
Useless parentheses. 1274
Useless parentheses. 1282
Useless parentheses. 1291
Useless parentheses. 1308
Useless parentheses. 1312
Useless parentheses. 1334
Useless parentheses. 1341
Useless parentheses. 1348
Useless parentheses. 1357
Useless parentheses. 1364
Useless parentheses. 1368
Useless parentheses. 1379
Useless parentheses. 1381
Useless parentheses. 1389
Useless parentheses. 1396
Useless parentheses. 1403
Useless parentheses. 1411
Useless parentheses. 1421
Useless parentheses. 1423
Useless parentheses. 1428
Useless parentheses. 1475
Useless parentheses. 1504

com/buckosoft/PicMan/db/FiltersDaoJdbc.java

Violation Line
Avoid empty catch blocks 94–95
Useless parentheses. 107
Useless parentheses. 119
Useless parentheses. 135
Useless parentheses. 145
Useless parentheses. 155
Useless parentheses. 171
Useless parentheses. 183
Useless parentheses. 192
Useless parentheses. 197
Useless parentheses. 241
Useless parentheses. 246
Avoid unused constructor parameters such as 'pic'. 288
Avoid unused constructor parameters such as 's'. 298
Avoid unused constructor parameters such as 'size'. 298
Avoid unused constructor parameters such as 'unused1'. 322
Avoid unused constructor parameters such as 'unused2'. 322
Avoid empty catch blocks 340
Useless parentheses. 351
Avoid empty catch blocks 377
Useless parentheses. 388
Useless parentheses. 416
Useless parentheses. 436

com/buckosoft/PicMan/db/FiltersMicroSetsDaoJdbc.java

Violation Line
Useless parentheses. 64
Useless parentheses. 86
Useless parentheses. 99
Avoid unused constructor parameters such as 'pid'. 124
Avoid unused constructor parameters such as 'sid'. 129
Avoid unused constructor parameters such as 'pid'. 129
Avoid unused constructor parameters such as 'unused'. 135
Avoid unused constructor parameters such as 'value'. 140
Avoid unused constructor parameters such as 'unused'. 140
Useless parentheses. 152

com/buckosoft/PicMan/db/HibernateUtil.java

Violation Line
Useless parentheses. 27

com/buckosoft/PicMan/db/MetaSetsDaoJdbc.java

Violation Line
Useless parentheses. 81
Avoid unused constructor parameters such as 'sid'. 126
Useless parentheses. 150
Useless parentheses. 196

com/buckosoft/PicMan/db/MosaicBatchesDaoJdbc.java

Violation Line
Useless parentheses. 69
Useless parentheses. 83
Useless parentheses. 84
Useless parentheses. 98
Useless parentheses. 107
Avoid unused constructor parameters such as 'mbid'. 134
Useless parentheses. 145

com/buckosoft/PicMan/db/MosaicTilesDaoJdbc.java

Violation Line
Useless parentheses. 65
Useless parentheses. 77
Avoid unused constructor parameters such as 'mid'. 114
Useless parentheses. 128

com/buckosoft/PicMan/db/MosaicVectorsDaoJdbc.java

Violation Line
Useless parentheses. 105
Avoid unused constructor parameters such as 'pid'. 116
Useless parentheses. 140

com/buckosoft/PicMan/db/MosaicsDaoJdbc.java

Violation Line
Useless parentheses. 56
Useless parentheses. 68
Useless parentheses. 84
Useless parentheses. 130
Avoid unused constructor parameters such as 'mid'. 164
Avoid unused constructor parameters such as 'sid'. 170
Avoid unused constructor parameters such as 'engine'. 170
Avoid unused constructor parameters such as 'tileHeight'. 170
Avoid unused constructor parameters such as 'masterPic'. 170
Useless parentheses. 192
Avoid unused constructor parameters such as 'mid'. 287
Useless parentheses. 297

com/buckosoft/PicMan/db/PicsDaoJdbc.java

Violation Line
Useless parentheses. 63
Useless parentheses. 109
Useless parentheses. 123
Useless parentheses. 138
Useless parentheses. 151
Useless parentheses. 165
Useless parentheses. 177
Useless parentheses. 191
Useless parentheses. 209
Useless parentheses. 218
Useless parentheses. 227
Useless parentheses. 237
Useless parentheses. 282
Useless parentheses. 285
Useless parentheses. 286
Useless parentheses. 291
Useless parentheses. 299
Useless parentheses. 308
Avoid unused constructor parameters such as 'name'. 322
Avoid unused constructor parameters such as 'pid'. 327
Avoid unused constructor parameters such as 'name'. 332
Avoid unused constructor parameters such as 'unused'. 332
Avoid unused constructor parameters such as 'calendar'. 342
Avoid unused constructor parameters such as 'dirName'. 347
Avoid unused constructor parameters such as 'rid'. 347
Avoid unused constructor parameters such as 'unused'. 353
Avoid unused constructor parameters such as 'r'. 363
Avoid unused constructor parameters such as 'rid'. 363
Avoid unused constructor parameters such as 'unused'. 370
Do not use if statements that are always true or always false 377
Avoid empty catch blocks 381
Avoid unused constructor parameters such as 'sum'. 393
Do not use if statements that are always true or always false 401
Avoid empty catch blocks 405
Useless parentheses. 448
Avoid unused constructor parameters such as 'cacheDir'. 465
Avoid unused constructor parameters such as 'rid'. 475
Avoid unused constructor parameters such as 'unused'. 475

com/buckosoft/PicMan/db/PostersDaoJdbc.java

Violation Line
Useless parentheses. 56
Useless parentheses. 72
Useless parentheses. 118
Avoid unused constructor parameters such as 'pid'. 152
Useless parentheses. 168
Avoid unused constructor parameters such as 'pid'. 251
Useless parentheses. 261

com/buckosoft/PicMan/db/RootsDao.java

Violation Line
Avoid modifiers which are implied by the context 27
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 84

com/buckosoft/PicMan/db/RootsDaoJdbc.java

Violation Line
No need to import a type that lives in the same package 29
Useless parentheses. 62
Useless parentheses. 68
Useless parentheses. 84
Useless parentheses. 100
Useless parentheses. 109
Useless parentheses. 122
Useless parentheses. 124
Useless parentheses. 137
Useless parentheses. 139
Useless parentheses. 147
Useless parentheses. 198
Avoid unused constructor parameters such as 'root'. 216
Useless parentheses. 242

com/buckosoft/PicMan/db/SetTimestampsDaoJdbc.java

Violation Line
Useless parentheses. 60
Avoid empty catch blocks 105
Useless parentheses. 107

com/buckosoft/PicMan/db/SetsDao.java

Violation Line
Avoid modifiers which are implied by the context 27
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 84
Avoid modifiers which are implied by the context 90

com/buckosoft/PicMan/db/SetsDaoJdbc.java

Violation Line
Useless parentheses. 59
Useless parentheses. 68
Useless parentheses. 84
Useless parentheses. 100
Useless parentheses. 116
Useless parentheses. 125
Useless parentheses. 138
Useless parentheses. 140
Useless parentheses. 153
Useless parentheses. 155
Unnecessary use of fully qualified name 'java.sql.SQLException' due to existing import 'java.sql.SQLException' 228
Useless parentheses. 231
Avoid unused constructor parameters such as 'set'. 249
Useless parentheses. 278

com/buckosoft/PicMan/db/SystemDao.java

Violation Line
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 30

com/buckosoft/PicMan/db/SystemDaoJdbc.java

Violation Line
No need to import a type that lives in the same package 28
Useless parentheses. 61
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 83
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 95
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 97
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 99
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 101
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 103
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 111
Useless parentheses. 115
Useless parentheses. 144
Useless parentheses. 267

com/buckosoft/PicMan/db/UsersDaoJdbc.java

Violation Line
Useless parentheses. 116
Avoid unused constructor parameters such as 'userid'. 136
Useless parentheses. 146
Useless parentheses. 278

com/buckosoft/PicMan/db/VirginsDaoJdbc.java

Violation Line
Useless parentheses. 60
Useless parentheses. 72
Useless parentheses. 117
Useless parentheses. 120
Avoid unused constructor parameters such as 'max'. 132
Avoid unused constructor parameters such as 'picName'. 138
Useless parentheses. 148

com/buckosoft/PicMan/db/logic/MetaSetFilter.java

Violation Line
Useless parentheses. 52
Useless parentheses. 105
Avoid empty if statements 158–160
Useless parentheses. 166

com/buckosoft/PicMan/dom/DirsInDirDom.java

Violation Line
Useless parentheses. 41

com/buckosoft/PicMan/dom/EngineReportDom.java

Violation Line
Useless parentheses. 85
Useless parentheses. 133

com/buckosoft/PicMan/dom/FilesInDirCountDom.java

Violation Line
Useless parentheses. 26

com/buckosoft/PicMan/dom/FiltersChangedDom.java

Violation Line
These nested if statements could be combined 56–57

com/buckosoft/PicMan/dom/ImportAnalyzeDom.java

Violation Line
Useless parentheses. 39

com/buckosoft/PicMan/dom/ImportPicsDom.java

Violation Line
Useless parentheses. 38
Useless parentheses. 53

com/buckosoft/PicMan/dom/JobLogEntryDom.java

Violation Line
Useless parentheses. 37

com/buckosoft/PicMan/dom/MosaicBatchSetupDom.java

Violation Line
Avoid unused method parameters such as 'pmf'. 57

com/buckosoft/PicMan/dom/PicBrowserDom.java

Violation Line
Avoid empty catch blocks 55

com/buckosoft/PicMan/dom/RootsDom.java

Violation Line
Useless parentheses. 43

com/buckosoft/PicMan/dom/SetManDom.java

Violation Line
Useless parentheses. 53

com/buckosoft/PicMan/dom/SyncStatusDom.java

Violation Line
Avoid unused method parameters such as 'pmf'. 56
Useless parentheses. 64

com/buckosoft/PicMan/domain/Chain.java

Violation Line
Useless parentheses. 42
Useless parentheses. 45
Useless parentheses. 87
Useless parentheses. 153
Useless parentheses. 164
Useless parentheses. 166

com/buckosoft/PicMan/domain/Contact.java

Violation Line
Useless parentheses. 74
Useless parentheses. 90
Useless parentheses. 92

com/buckosoft/PicMan/domain/ContactParams.java

Violation Line
Useless parentheses. 58
Useless parentheses. 60
Useless parentheses. 63
Useless parentheses. 65
Useless parentheses. 68
Useless parentheses. 70
Useless parentheses. 71
Useless parentheses. 84
Useless parentheses. 86
Useless parentheses. 88
Useless parentheses. 90
Useless parentheses. 91
Useless parentheses. 154–156
Useless parentheses. 164–165

com/buckosoft/PicMan/domain/DataStrings.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 16

com/buckosoft/PicMan/domain/Filter.java

Violation Line
Useless parentheses. 75
Useless parentheses. 76
Useless parentheses. 86
Useless parentheses. 110

com/buckosoft/PicMan/domain/JobLogEntry.java

Violation Line
Useless parentheses. 71
Useless parentheses. 80
Useless parentheses. 82
Useless parentheses. 84
Useless parentheses. 86
Useless parentheses. 88
Useless parentheses. 90
Useless parentheses. 92
Useless parentheses. 94
Useless parentheses. 96
Useless parentheses. 98
Useless parentheses. 175
Useless parentheses. 185
Useless parentheses. 190
Useless parentheses. 191
Useless parentheses. 196
Useless parentheses. 198

com/buckosoft/PicMan/domain/MetaSet.java

Violation Line
Useless parentheses. 72
Useless parentheses. 79
Useless parentheses. 89

com/buckosoft/PicMan/domain/MetaSetRule.java

Violation Line
Useless parentheses. 90
Useless parentheses. 92
Useless parentheses. 94
Useless parentheses. 96
Useless parentheses. 97
Useless parentheses. 162

com/buckosoft/PicMan/domain/Mosaic.java

Violation Line
Useless parentheses. 35

com/buckosoft/PicMan/domain/Pic.java

Violation Line
Useless parentheses. 44
Useless parentheses. 47
Useless parentheses. 49
Useless parentheses. 51
Useless parentheses. 64
Useless parentheses. 67

com/buckosoft/PicMan/domain/Poster.java

Violation Line
Useless parentheses. 47
Avoid empty catch blocks 48
Useless parentheses. 65
Avoid empty catch blocks 66
Useless parentheses. 83
Avoid empty catch blocks 84
Useless parentheses. 101
Avoid empty catch blocks 102
Useless parentheses. 119
Avoid empty catch blocks 120
Useless parentheses. 137
Avoid empty catch blocks 138
Useless parentheses. 150
Useless parentheses. 159
Useless parentheses. 160
Useless parentheses. 175
Useless parentheses. 176
Useless parentheses. 191
Useless parentheses. 192
Useless parentheses. 207
Useless parentheses. 208
Useless parentheses. 223
Useless parentheses. 224
Useless parentheses. 239
Useless parentheses. 240
Useless parentheses. 255
Useless parentheses. 256
Useless parentheses. 271
Useless parentheses. 272

com/buckosoft/PicMan/domain/PosterParams.java

Violation Line
Useless parentheses. 35

com/buckosoft/PicMan/domain/Set.java

Violation Line
Useless parentheses. 59
Useless parentheses. 68
Useless parentheses. 70
Useless parentheses. 100
Useless parentheses. 109
Useless parentheses. 161

com/buckosoft/PicMan/domain/SetSize.java

Violation Line
Useless parentheses. 41–42
Useless parentheses. 45–46

com/buckosoft/PicMan/domain/SetSizeCount.java

Violation Line
Useless parentheses. 27
Useless parentheses. 30

com/buckosoft/PicMan/domain/SyncLogEntry.java

Violation Line
Useless parentheses. 40
Useless parentheses. 42
Useless parentheses. 44
Useless parentheses. 46
Useless parentheses. 48
Useless parentheses. 50
Useless parentheses. 52

com/buckosoft/PicMan/domain/System.java

Violation Line
Useless parentheses. 59
Useless parentheses. 61
Useless parentheses. 63
Useless parentheses. 65
Useless parentheses. 67
Useless parentheses. 81
Useless parentheses. 84
Useless parentheses. 310–312
Useless parentheses. 318–319

com/buckosoft/PicMan/domain/Thumbnail.java

Violation Line
Useless parentheses. 23
Useless parentheses. 25

com/buckosoft/PicMan/domain/Virgin.java

Violation Line
Useless parentheses. 20

com/buckosoft/PicMan/image/PicReader.java

Violation Line
Useless parentheses. 63
Useless parentheses. 68
Useless parentheses. 73
Useless parentheses. 83
Useless parentheses. 96
Useless parentheses. 113
Useless parentheses. 118
Avoid unused method parameters such as 'label'. 126
Useless parentheses. 137
Useless parentheses. 151
Avoid empty catch blocks 164
Useless parentheses. 166
Avoid empty catch blocks 175
Useless parentheses. 177
Avoid empty catch blocks 193
Avoid empty catch blocks 197–199
Useless parentheses. 272
Useless parentheses. 288
Useless parentheses. 298
Useless parentheses. 316
Useless parentheses. 317
Useless parentheses. 324
Useless parentheses. 327
Useless parentheses. 336
Useless parentheses. 349
Avoid empty catch blocks 362
Useless parentheses. 364
Avoid empty catch blocks 373
Useless parentheses. 375
Avoid empty catch blocks 392
Useless parentheses. 429
Useless parentheses. 446

com/buckosoft/PicMan/image/ThumbCache.java

Violation Line
Useless parentheses. 82
Useless parentheses. 136
Useless parentheses. 140
Useless parentheses. 142
Useless parentheses. 144
Useless parentheses. 163
Avoid empty catch blocks 174
Useless parentheses. 175
Avoid empty catch blocks 182
Useless parentheses. 183
Useless parentheses. 205
Avoid empty catch blocks 250–251
These nested if statements could be combined 310–312
Avoid empty if statements 310–312
These nested if statements could be combined 359–360
Useless parentheses. 415

com/buckosoft/PicMan/service/RootService.java

Violation Line
Avoid modifiers which are implied by the context 21

com/buckosoft/PicMan/service/SyncService.java

Violation Line
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 47

com/buckosoft/PicMan/service/support/KeyValueMapDeserializer.java

Violation Line
Useless parentheses. 169
Useless parentheses. 170
Useless parentheses. 171
Useless parentheses. 172
Useless parentheses. 173
Useless parentheses. 197
Useless parentheses. 202–203
Useless parentheses. 207

com/buckosoft/PicMan/service/support/KeyValueMapSerializer.java

Violation Line
Useless parentheses. 264
Useless parentheses. 269

com/buckosoft/PicMan/service/support/MapLabels.java

Violation Line
Avoid modifiers which are implied by the context 5
Avoid modifiers which are implied by the context 7

com/buckosoft/PicMan/service/sync/SyncServiceImpl.java

Violation Line
Useless parentheses. 56

com/buckosoft/PicMan/util/DateUtil.java

Violation Line
Useless parentheses. 29
Useless parentheses. 57
Useless parentheses. 62
Useless parentheses. 75
Useless parentheses. 99

com/buckosoft/PicMan/util/FilterUtil.java

Violation Line
Useless parentheses. 94

com/buckosoft/PicMan/util/SetsCRC.java

Violation Line
Useless parentheses. 23

com/buckosoft/PicMan/web/ChainManForm.java

Violation Line
Useless parentheses. 34
Useless parentheses. 37
Useless parentheses. 40
Useless parentheses. 42
Useless parentheses. 44
Useless parentheses. 46
Useless parentheses. 114
Useless parentheses. 115

com/buckosoft/PicMan/web/ChainManFormController.java

Violation Line
Useless parentheses. 90
Useless parentheses. 167
Useless parentheses. 188
Useless parentheses. 206
Useless parentheses. 207

com/buckosoft/PicMan/web/DatabaseConverterForm.java

Violation Line
Useless parentheses. 34
Useless parentheses. 37

com/buckosoft/PicMan/web/DatabaseConverterFormController.java

Violation Line
Useless parentheses. 89
Useless parentheses. 179

com/buckosoft/PicMan/web/EngineReportPageController.java

Violation Line
These nested if statements could be combined 61–62

com/buckosoft/PicMan/web/FilterEditPageController.java

Violation Line
Useless parentheses. 53

com/buckosoft/PicMan/web/FilterReportPageController.java

Violation Line
Useless parentheses. 38
Useless parentheses. 41
Useless parentheses. 51

com/buckosoft/PicMan/web/FilterReportSummaryPageController.java

Violation Line
Useless parentheses. 58
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 58

com/buckosoft/PicMan/web/GetPicController.java

Violation Line
Useless parentheses. 76
Useless parentheses. 96
Useless parentheses. 102
Useless parentheses. 147

com/buckosoft/PicMan/web/GetThumbNailController.java

Violation Line
Useless parentheses. 101
Useless parentheses. 107
Useless parentheses. 120
Useless parentheses. 164

com/buckosoft/PicMan/web/HelloPageController.java

Violation Line
Useless parentheses. 30

com/buckosoft/PicMan/web/HomePageController.java

Violation Line
Useless parentheses. 47
Useless parentheses. 56
Useless parentheses. 70

com/buckosoft/PicMan/web/HtmlUtils.java

Violation Line
Useless parentheses. 35
Useless parentheses. 52
Useless parentheses. 83
Useless parentheses. 197

com/buckosoft/PicMan/web/ImportPicsPageController.java

Violation Line
Useless parentheses. 43

com/buckosoft/PicMan/web/JobLogReportPageController.java

Violation Line
Useless parentheses. 28
Useless parentheses. 35

com/buckosoft/PicMan/web/MetaSetForm.java

Violation Line
Useless parentheses. 28
Useless parentheses. 31

com/buckosoft/PicMan/web/MetaSetFormController.java

Violation Line
Useless parentheses. 46
Useless parentheses. 49
Useless parentheses. 93
Useless parentheses. 132
Useless parentheses. 142
Useless parentheses. 149
Useless parentheses. 156
Useless parentheses. 165
Useless parentheses. 178
Useless parentheses. 204
Useless parentheses. 207

com/buckosoft/PicMan/web/MosaicAnalyseAjaxController.java

Violation Line
These nested if statements could be combined 56–57
Useless parentheses. 69

com/buckosoft/PicMan/web/MosaicAnalysePageController.java

Violation Line
Useless parentheses. 51

com/buckosoft/PicMan/web/MosaicAnalysePicController.java

Violation Line
Useless parentheses. 103
Useless parentheses. 112

com/buckosoft/PicMan/web/MosaicBatchSetupFormController.java

Violation Line
Useless parentheses. 100
Useless parentheses. 188
Useless parentheses. 191
Useless parentheses. 235
Useless parentheses. 239
Useless parentheses. 278

com/buckosoft/PicMan/web/MosaicDisplayConfigForm.java

Violation Line
Useless parentheses. 28

com/buckosoft/PicMan/web/MosaicDisplayConfigFormController.java

Violation Line
Useless parentheses. 68
Useless parentheses. 109

com/buckosoft/PicMan/web/MosaicDisplayPageController.java

Violation Line
Useless parentheses. 44
Useless parentheses. 47
Useless parentheses. 58

com/buckosoft/PicMan/web/MosaicSetupForm.java

Violation Line
Useless parentheses. 66
Useless parentheses. 355

com/buckosoft/PicMan/web/MosaicSetupFormController.java

Violation Line
Useless parentheses. 94
Useless parentheses. 191
Useless parentheses. 194

com/buckosoft/PicMan/web/PicBrowserAjaxController.java

Violation Line
Useless parentheses. 73
Avoid empty catch blocks 177
Useless parentheses. 206

com/buckosoft/PicMan/web/PicBrowserPageController.java

Violation Line
Useless parentheses. 43

com/buckosoft/PicMan/web/PicFilterWeb.java

Violation Line
Useless parentheses. 30
Useless parentheses. 153
Useless parentheses. 158

com/buckosoft/PicMan/web/PosterDisplayPageController.java

Violation Line
Useless parentheses. 44
Useless parentheses. 47
Useless parentheses. 58

com/buckosoft/PicMan/web/PosterSetupForm.java

Violation Line
Useless parentheses. 58
Useless parentheses. 282

com/buckosoft/PicMan/web/PosterSetupFormController.java

Violation Line
Useless parentheses. 89
Useless parentheses. 136
Useless parentheses. 139

com/buckosoft/PicMan/web/RootManForm.java

Violation Line
Useless parentheses. 35
Useless parentheses. 44
Useless parentheses. 57
Useless parentheses. 62
Useless parentheses. 67
Useless parentheses. 73
Useless parentheses. 78

com/buckosoft/PicMan/web/RootManFormController.java

Violation Line
Useless parentheses. 65
Useless parentheses. 111

com/buckosoft/PicMan/web/ScanForNewPicsForm.java

Violation Line
Useless parentheses. 26
Useless parentheses. 29
Useless parentheses. 33

com/buckosoft/PicMan/web/ScanForNewPicsFormController.java

Violation Line
Useless parentheses. 34
Useless parentheses. 54
Useless parentheses. 94
Useless parentheses. 97

com/buckosoft/PicMan/web/SetManForm.java

Violation Line
Useless parentheses. 32
Useless parentheses. 35
Useless parentheses. 42
Useless parentheses. 43
Useless parentheses. 45
Useless parentheses. 62
Useless parentheses. 64

com/buckosoft/PicMan/web/SetManFormController.java

Violation Line
Useless parentheses. 43
Useless parentheses. 69
Useless parentheses. 123
Useless parentheses. 146

com/buckosoft/PicMan/web/SetSizeWebTable.java

Violation Line
Useless parentheses. 34
Useless parentheses. 76
Useless parentheses. 88
Useless parentheses. 90

com/buckosoft/PicMan/web/ShowErrorPageController.java

Violation Line
Useless parentheses. 31

com/buckosoft/PicMan/web/SlideShowPageController.java

Violation Line
Useless parentheses. 62

com/buckosoft/PicMan/web/SpinContactsForm.java

Violation Line
Useless parentheses. 32
Useless parentheses. 35
Useless parentheses. 37
Useless parentheses. 40
Useless parentheses. 43
Useless parentheses. 44
Useless parentheses. 45
Useless parentheses. 47
Useless parentheses. 50
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 74
Useless parentheses. 85

com/buckosoft/PicMan/web/SpinContactsFormController.java

Violation Line
Useless parentheses. 40
Useless parentheses. 43
Avoid empty catch blocks 73
Useless parentheses. 80
Avoid empty catch blocks 106
Useless parentheses. 142
Useless parentheses. 145

com/buckosoft/PicMan/web/SyncSetupPageController.java

Violation Line
Useless parentheses. 53
Useless parentheses. 59

com/buckosoft/PicMan/web/SyncStatusPageController.java

Violation Line
Useless parentheses. 50
Useless parentheses. 56

com/buckosoft/PicMan/web/SystemSetupForm.java

Violation Line
Useless parentheses. 31
Useless parentheses. 34

com/buckosoft/PicMan/web/SystemSetupFormController.java

Violation Line
Useless parentheses. 47
Useless parentheses. 82
Useless parentheses. 160

com/buckosoft/PicMan/web/UserConfigForm.java

Violation Line
Useless parentheses. 32

com/buckosoft/PicMan/web/UserConfigFormController.java

Violation Line
Useless parentheses. 63
Useless parentheses. 98

com/buckosoft/PicMan/web/VirginProcessPageController.java

Violation Line
Useless parentheses. 46

com/buckosoft/PicMan/web/WebAjaxController.java

Violation Line
These nested if statements could be combined 83–84
Useless parentheses. 157
Useless parentheses. 163
Useless parentheses. 168

com/buckosoft/PicMan/web/WebEditController.java

Violation Line
These nested if statements could be combined 53–54
Useless parentheses. 72
Avoid unused method parameters such as 'response'. 96
Useless parentheses. 103
Useless parentheses. 108
Useless parentheses. 112

com/buckosoft/PicMan/web/WebFilterController.java

Violation Line
Useless parentheses. 75
Useless parentheses. 103